[ISSUE-1242] prevented weird exceptions related to integer handling #1244
Conversation
|
@2ps could wrap via str() instead of f-strings. |
|
@2ps please use format in that situation please? |
|
Apologies
Apologies for the late response, will do. That said, the setup.py file indicates that python2 isn't supported -- we may also want to update that to indicate support for python 2 and the eol'd python 2.7. |
if keys or values in the response json are `int`s, the `k + ": " + v` will fail because of an `int` is not a `str`. In order to avoid this, we can either use `%`-formatting, `.format` formatting, or f-strings. We chose `.format` for compatability, but regardless of which direction, the issue should be addressed one of those ways.
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1244 +/- ##
==========================================
- Coverage 34.47% 34.45% -0.02%
==========================================
Files 44 44
Lines 8105 8108 +3
Branches 1118 1119 +1
==========================================
Hits 2794 2794
- Misses 5197 5200 +3
Partials 114 114
☔ View full report in Codecov by Sentry. |
|
Thanks |
if keys or values in the response json are
ints, thek + ": " + vexpression will fail because anintis not astr. In order to avoid this, we can either use%-formatting,.formatformatting, or f-strings. I chose f-strings for usability, but regardless of which direction, the issue should be addressed one of those ways.addresses #1242